Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(latest_version): double check new releases #351

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

JosephKav
Copy link
Collaborator

github responses may omit a version tag if you're querying very frequently

This should prevent cases where you get notified for older releases when you're querying GitHub a lot
296758444-34aad0f5-ea4d-4666-8973-effdc24b9c35

@JosephKav JosephKav added the bug Something isn't working label Jan 17, 2024
@JosephKav JosephKav linked an issue Jan 17, 2024 that may be closed by this pull request
@JosephKav JosephKav force-pushed the 349-bug-duplicate-notifications-sent branch 2 times, most recently from 475ef94 to 0c0c709 Compare January 17, 2024 14:57
github responses *may* omit a version tag if you're querying *very* frequently
@JosephKav JosephKav force-pushed the 349-bug-duplicate-notifications-sent branch from 0c0c709 to 5610a28 Compare January 17, 2024 15:17
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4dd89a) 98.67% compared to head (5610a28) 98.67%.

❗ Current head 5610a28 differs from pull request most recent head f226b4b. Consider uploading reports for the commit f226b4b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   98.67%   98.67%   +0.01%     
==========================================
  Files          87       87              
  Lines        8667     8678      +11     
==========================================
+ Hits         8551     8562      +11     
  Misses         90       90              
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JosephKav JosephKav merged commit ec7fa14 into master Jan 17, 2024
5 checks passed
@JosephKav JosephKav deleted the 349-bug-duplicate-notifications-sent branch January 17, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Duplicate notifications sent
1 participant