feat(web): 'test notify' button on create/edit #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* reappear when all elements removed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 98.74% 98.78% +0.04%
==========================================
Files 87 90 +3
Lines 6882 7097 +215
==========================================
+ Hits 6795 7010 +215
Misses 61 61
Partials 26 26 ☔ View full report in Codecov by Sentry. |
JosephKav
force-pushed
the
master
branch
7 times, most recently
from
b72d581 to
036f112
Compare
JosephKav
force-pushed
the
368-feat-add-a-test-connection-for-notifiers
branch
from
1b3ec3c to
3dca862
Compare
JosephKav
force-pushed
the
368-feat-add-a-test-connection-for-notifiers
branch
from
4689718 to
3c4f299
Compare
JosephKav
force-pushed
the
368-feat-add-a-test-connection-for-notifiers
branch
4 times, most recently
from
6b521a2 to
2e1bf43
Compare
JosephKav
force-pushed
the
368-feat-add-a-test-connection-for-notifiers
branch
3 times, most recently
from
b563257 to
1f95e10
Compare
JosephKav
force-pushed
the
368-feat-add-a-test-connection-for-notifiers
branch
4 times, most recently
from
7ed684b to
47dcb09
Compare
JosephKav
force-pushed
the
368-feat-add-a-test-connection-for-notifiers
branch
from
47dcb09 to
21d30ef
Compare
also remove same-color from text-muted
* e.g. if you changed the config and restarted the service
* type was causing it to miss errors for notify.*.type
JosephKav
force-pushed
the
368-feat-add-a-test-connection-for-notifiers
branch
4 times, most recently
from
8d1317f to
d1edb5b
Compare
* send service_name and service_name_previous for test notifys * boolean with defaults needs useTimeout? * option for non-urls in FormItemWithPreview (slack/mattermost icon can be emoji) * form-validate returns true or fail message string
JosephKav
changed the title
* some places, empty arrays were undefined, which wasn't caught by .length also prettified rendering in cases of 4 or less services, not stretching them to the full width
JosephKav
force-pushed
the
368-feat-add-a-test-connection-for-notifiers
branch
from
34c0de5 to
dd3d02a
Compare
couldn't use the '-' to remove a command after their index was altered
rather than try and preview the URL each time the value changes (also sets this image onBlur)
* also adds checks for service_name_previous existing/not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added
/testdir that I plan to use for sharing funcs between testswill be adding an option to disable routes in config (create/edit/delete, test notify, refresh lv/dv, command/webhooks)