fix(docker): remove hardcoded USER to restore custom UID/GID support #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephKav
deleted the
519-bug-upgrade-from-018-to-0193-results-in-read-only-error-to-argusdb
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #520 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 120 120
Lines 10279 10279
=======================================
Hits 10130 10130
Misses 121 121
Partials 28 28 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, the entrypoint runs as 'argus:argus', so it wouldn't have permissions to change the UID/GID when ARGUS_UID/ARGUS_GID are set. This breaks upgrades as the file would be owned by a different user, so 911:911 wouldn't be able to write to the db.
fixes #519