feat(ui): service tags #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JosephKav
commented
Jan 21, 2025
•
JosephKav
commented
- feat(ui): service tags
- style: format configuration files for consistency
- fix(ui): ensure boolean options are always processesed with strToBoo
- fixes bug: service edit, latest/deployed version boolean options aren't loaded #517
- perf(ui): minimise state updates to reduce unnecessary re-renders
- refactor(log): centralise logging via logutil package
- rather than LogInit in all packages, just logutil.Init in cmd/argus and then use the logutil.Log in other packages.
- test(github): add access_token default to test cases
- was using ~30 of the 60 allowed github api requests in 1 test run. Down to ~5 now.
JosephKav
added
bug
JosephKav
force-pushed
the
feat/ui-service-tags
branch
from
28e9ad6 to
fdc4bab
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #522 +/- ##
==========================================
+ Coverage 98.56% 98.67% +0.12%
==========================================
Files 120 118 -2
Lines 10279 10314 +35
==========================================
+ Hits 10130 10176 +46
+ Misses 121 112 -9
+ Partials 28 26 -2 ☔ View full report in Codecov by Sentry. |
JosephKav
force-pushed
the
feat/ui-service-tags
branch
9 times, most recently
from
3be2e5c to
ca5e053
Compare
- add/reorder/remove service tags in edit modal - filter by tag(s) in select next to service search bar
- bump @tanstack/react-query from 5.64.1 to 5.64.2 - bump @tanstack/react-query-devtools from 5.64.1 to 5.64.2 - bump @types/node from 22.10.6 to 22.10.10 - bump @types/react from 19.0.6 to 19.0.8 - bump react-bootstrap from 2.10.7 to 2.10.8 - bump react-router-dom from 7.1.1 to 7.1.3 - bump react-select from 5.9.0 to 5.10.0 - bump vite from 6.0.9 to 6.0.11
Create new objects where necessary, rather than stringifying the entire state
- Add a new `logutil` package for centralised logging using `JLog`. - Migrated all packages to use `logutil.Log` instead of individual `jLog` variables. - Removed now-unnecessary `LogInit` functions and per-package `jLog` variables. - Ensures consistent logging configuration across all packages.
Was using ~30 of the 60 hourly github api requests in 1 test run. Down to ~5 now.
- godot - perfsprint - whitespace - unconvert - unused - usestdlibvars
JosephKav
force-pushed
the
feat/ui-service-tags
branch
from
ca5e053 to
a7a53fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.