Merge pull request #12 from release-engineering/leftover

Clean up the code
release-engineering · Jul 18, 2024 · 7b5ed6f · 7b5ed6f
2 parents 7f915c1 + 404b5ae
commit 7b5ed6f
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 12 deletions.
diff --git a/cloudpub/aws/service.py b/cloudpub/aws/service.py
@@ -511,7 +511,7 @@ def publish(self, metadata: AWSVersionMetadata) -> None:
             change_set["ChangeType"] = "UpdateDeliveryOptions"
             change_set["DetailsDocument"] = json_mapping.to_json()
 
-        if metadata.keepdraft or metadata.preview_only:
+        if metadata.keepdraft:
             log.info("Sending draft version to %s.", metadata.marketplace_entity_type)
             rsp: ChangeSetResponse = self.marketplace.start_change_set(
                 Catalog="AWSMarketplace", ChangeSet=[change_set], Intent="VALIDATE"

diff --git a/cloudpub/common.py b/cloudpub/common.py
@@ -20,7 +20,6 @@ def __init__(
         destination: str,
         overwrite: bool = False,
         keepdraft: bool = False,
-        preview_only: bool = False,
     ) -> None:
         """
         Create an instanece of PublishingMetadata.
@@ -39,16 +38,12 @@ def __init__(
             Whether to just associate the VM Image with the destination but avoid publishing or not.
             When set to `False` it will publish the content as GA.
             This defaults to `True`.
-        preview_only (boolean, optional)
-            Whether the final publish status should be ``preview`` (``True``)
-            or ``live`` (``False``). Defaults to ``False``.
         """
         self.image_path = image_path
         self.architecture = architecture
         self.destination = destination
         self.overwrite = overwrite
         self.keepdraft = keepdraft
-        self.preview_only = preview_only
         self.__validate()
 
     def __validate(self):

diff --git a/cloudpub/ms_azure/service.py b/cloudpub/ms_azure/service.py
@@ -781,6 +781,4 @@ def publish(self, metadata: AzurePublishingMetadata) -> None:
             self.ensure_can_publish(product.id)
 
             self._publish_preview(product, product_name)
-
-            if not metadata.preview_only:
-                self._publish_live(product, product_name)
+            self._publish_live(product, product_name)
diff --git a/docs/cloud_providers/models/aws.rst.incl b/docs/cloud_providers/models/aws.rst.incl
@@ -24,9 +24,6 @@ AWS Version Mapping
 .. autoclass:: cloudpub.models.aws.VersionMapping()
    :members:
 
-.. autoclass:: cloudpub.models.aws.DeliveryOptions()
-   :members:
-
 .. autoclass:: cloudpub.models.aws.DeliveryOption()
    :members: