-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle situation when _selinux_policy_version is not defined #66
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failed CI is because of #64
This is interesting, I see this for the first time. Do we really want to depend on specific selinux-policy version, and rebuild anytime they bump it? |
The rebuild would be needed only if the version of selinux is decreased. That will never happen. |
Ah,
|
Updated. I intentionally left it in two commits, so it is visible the interaction and intention. |
%endif | ||
Requires(post): /usr/sbin/semodule, /sbin/restorecon | ||
Requires(postun): /usr/sbin/semodule, /sbin/restorecon | ||
%{?selinux_requires} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks this macro is not yet finished :-( the %selinux_requires is not defined by redhat-rpm-config nor any other package in minimal buildroot. I reported this problem.
The docs are not updated: https://fedoraproject.org/wiki/SELinux/IndependentPolicy#Example_spec_file_changes_to_incorporate_-selinux_subpackage
IOW, we need to do:
BuildRequires: selinux-policy-devel
%{?selinux_requires}
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.