Retire native ubipop publishing [RHELDST-25072] #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 98.77% 98.70% -0.07%
==========================================
Files 7 6 -1
Lines 735 696 -39
==========================================
- Hits 726 687 -39
Misses 9 9 ☔ View full report in Codecov by Sentry. |
Gdetrane
force-pushed
the
retire-native-publishing
branch
from
dda36b1 to
ba22d9f
Compare
|
run tests |
rbikar
requested changes
Dec 4, 2024
Gdetrane
force-pushed
the
retire-native-publishing
branch
from
ba22d9f to
7513884
Compare
Gdetrane
added a commit
to Gdetrane/ubi-population-tool
that referenced
this pull request
Dec 5, 2024
Update lock file with a separate PR, based on the recent pyproject.toml changes merged in PR release-engineering#242, which caused conflict in PR release-engineering#243. This PR is solely meant for rebasing.
rbikar
pushed a commit
that referenced
this pull request
Dec 5, 2024
Gdetrane
force-pushed
the
retire-native-publishing
branch
from
7513884 to
eb35d85
Compare
|
run tests |
|
@Gdetrane |
+ Remove `cdn.py` module containing the `Publisher` class + Remove the *UBIPOP_SKIP_PUBLISH* env variable used for switching between publishers + Removed the *publisher* option for classes using it
Gdetrane
force-pushed
the
retire-native-publishing
branch
from
eb35d85 to
0702979
Compare
|
@rbikar should be okay now |
|
run tests |
|
@Gdetrane |
rbikar
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cdn.pymodule containing thePublisherclass