Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for targeting PHP 8.4 #474

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Add support for targeting PHP 8.4 #474

merged 1 commit into from
Jan 17, 2025

Conversation

sj-i
Copy link
Member

@sj-i sj-i commented Jan 15, 2025

No description provided.

@sj-i sj-i added the enhancement New feature or request label Jan 15, 2025
@sj-i sj-i added this to the 0.12.0 milestone Jan 15, 2025
@sj-i sj-i force-pushed the php84 branch 2 times, most recently from b249b1e to 3a1a35f Compare January 17, 2025 15:58
@coveralls
Copy link

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 12832837311

Details

  • 19 of 20 (95.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 81.9%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Lib/PhpInternals/Opcodes/OpcodeV84.php 1 2 50.0%
Totals Coverage Status
Change from base Build 12794615886: 0.04%
Covered Lines: 5570
Relevant Lines: 6801

💛 - Coveralls

@sj-i sj-i force-pushed the php84 branch 2 times, most recently from e3eef76 to f23c85e Compare January 17, 2025 16:16
@sj-i sj-i changed the title Add initial support for targeting PHP 8.4 Add support for targeting PHP 8.4 Jan 17, 2025
@sj-i sj-i merged commit f59e702 into 0.12.x Jan 17, 2025
6 checks passed
@sj-i sj-i deleted the php84 branch January 17, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants