[pull] master from kimden:master

.github/ISSUE_TEMPLATE/defect.yml

@@ -0,0 +1,89 @@
+name: Defect
+description: Report bugs, crashes, or unintended behavior
+labels: ['T: bug']
+
+body:
+
+  - type: textarea
+    id: description
+    attributes:
+      label: Description
+      description: Provide a clear and concise explanation of the problem encountered.
+    validations:
+      required: true
+
+  - type: textarea
+    id: to_reproduce
+    attributes:
+      label: Steps to reproduce
+      description: Outline the exact sequence of actions required to reproduce the issue.
+      placeholder: |
+        1. Launch SuperTuxKart
+        2. Navigate to [specific menu/location]
+        3. Perform [specific action]
+        4. Observe unexpected behavior
+    validations:
+      required: true
+
+  - type: textarea
+    id: config
+    attributes:
+      label: Configuration
+      description: |
+        Include the following details to help us diagnose the issue:
+        - SuperTuxKart version (visible in the "About" menu)
+        - Installation source (official website, package manager, etc.)
+        - Operating system and version
+        - CPU/GPU specifications
+        - Controller/keyboard type (if relevant)
+      placeholder: |
+        SuperTuxKart version: 1.4
+        Installation source: Official repository
+        OS: Ubuntu 24.04
+        CPU: i5-10400
+        GPU: RX 580
+        Input device: USB keyboard
+    validations:
+      required: true
+
+  - type: textarea
+    id: error_msg
+    attributes:
+      label: Error message
+      description: |
+        If an error message was shown, please paste the complete error message, or a screenshot of it.
+      value: |
+        ```
+        [Paste error message here]
+        ```
+
+  - type: textarea
+    id: stdout
+    attributes:
+      label: Log File (stdout.log)
+      description: |
+        Attach the log file (stdout.log) from your latest session where the issue occurred.
+        File location
+        - Windows: %appdata%\supertuxkart\config-0.10\stdout.log
+        - macOS: ~/Library/Application Support/supertuxkart/config-0.10/stdout.log
+        - Linux and other Unix-based systems: 
+          $XDG_CONFIG_HOME/supertuxkart/config-0.10/stdout.log 
+          or ~/.config/supertuxkart/config-0.10/stdout.log
+      value: |
+        ```
+        [Paste contents of stdout.log here]
+        ```
+
+  - type: textarea
+    id: input
+    attributes:
+      label: Input Configuration (input.xml)
+      description: |
+        If your issue is related to the input config (gamepads, keyboards), 
+        please provide your file input.xml located in the same directory as stdout.log.
+      value: |
+        ```
+        [Paste contents of input.xml here]
+        ```
+
+

.github/ISSUE_TEMPLATE/enhancement.yml

@@ -0,0 +1,13 @@
+name: Enhancement
+description: Request for new features
+labels: ['T: Suggestion']
+
+body:
+  - type: textarea
+    id: description
+    attributes:
+      label: Description
+      description: |
+        If applicable, add screenshots or mockups to help explain your request.
+    validations:
+      required: true

.github/workflows/apple.yml

@@ -49,7 +49,7 @@ jobs:
             echo "cache_$number=apple-${{ github.ref }}-${{ matrix.arch }}-${{ matrix.platform }}-$id" >> $GITHUB_ENV
           done
       - name: Handle build cache
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         with:
           path: |
             build
@@ -93,7 +93,7 @@ jobs:
           make -j4
           mv bin ../${{ steps.sysroot.outputs.lowercase }}-${{ matrix.arch }}
       - name: Upload binaries
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: ${{ steps.sysroot.outputs.lowercase }}-${{ matrix.arch }}
           path: ${{ steps.sysroot.outputs.lowercase }}-${{ matrix.arch }}
@@ -131,7 +131,7 @@ jobs:
           echo "${{ env.release_name }}"
           echo "${{ env.release_pre }}"
       - name: Download binaries
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v4
       - name: Mask developer name
         run: |
           echo "::add-mask::${{ secrets.MAC_DEVELOPER_NAME }}"
@@ -151,7 +151,8 @@ jobs:
           HOMEBREW_NO_AUTO_UPDATE=1 brew install dylibbundler
           lipo -create ./macosx-x86_64/supertuxkart.app/Contents/MacOS/supertuxkart ./macosx-arm64/supertuxkart.app/Contents/MacOS/supertuxkart -output ./macosx-arm64/supertuxkart.app/Contents/MacOS/supertuxkart
           chmod 755 ./macosx-arm64/supertuxkart.app/Contents/MacOS/supertuxkart
-          dylibbundler -od -b -x ./macosx-arm64/supertuxkart.app/Contents/MacOS/supertuxkart -d ./macosx-arm64/supertuxkart.app/Contents/libs/ -p @executable_path/../libs/ -s dependencies-macosx/lib -ns
+          install_name_tool -change libcurl.4.dylib @rpath/libcurl.4.dylib ./macosx-arm64/supertuxkart.app/Contents/MacOS/supertuxkart
+          dylibbundler -od -b -x ./macosx-arm64/supertuxkart.app/Contents/MacOS/supertuxkart -d ./macosx-arm64/supertuxkart.app/Contents/libs/ -p @executable_path/../libs/ -s ./dependencies-macosx/lib -ns
           # We use SDL_Vulkan_LoadLibrary for 10.9 compatibility, so otool -L supertuxkart has no libMoltenVK.dylib
           cp ./dependencies-macosx/lib/libMoltenVK.dylib ./macosx-arm64/supertuxkart.app/Contents/libs/
           cd ./macosx-arm64/supertuxkart.app/Contents/Resources/data

.github/workflows/switch.yml

@@ -72,7 +72,7 @@ jobs:
             echo "cache_$number=switch-${{ github.ref }}-$id" >> $GITHUB_ENV
           done
       - name: Handle build cache
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         with:
           # This is unnecessarily verbose and might break, but again ! seems broken
           # See: https://github.com/Mstrodl/stk-code/runs/2333673736?check_suite_focus=true#step:16:34

.github/workflows/windows.yml

@@ -15,6 +15,9 @@ jobs:
       matrix:
         arch: [i686, x86_64, armv7, aarch64]
         os: [windows-latest, ubuntu-latest]
+        exclude:
+          - arch: armv7
+            os: windows-latest
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v2
@@ -56,7 +59,7 @@ jobs:
             echo "cache_$number=windows-${{ github.ref }}-${{ matrix.arch }}-${{ matrix.os }}-$id" >> $GITHUB_ENV
           done
       - name: Handle build cache
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         with:
           path: |
             build
@@ -149,21 +152,21 @@ jobs:
           mv COPYING tools
       - name: Upload binaries of MinGW
         if: ${{ matrix.os == 'ubuntu-latest' }}
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: ${{ matrix.arch }}
           path: build/bin/*
       - name: Upload stk-code/data
         # We only need to upload stk-code/data once
         if: ${{ matrix.os == 'ubuntu-latest' && matrix.arch == 'i686'}}
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: data
           path: data
       - name: Upload stk-code/tools
         # We only need to upload stk-code/tools once
         if: ${{ matrix.os == 'ubuntu-latest' && matrix.arch == 'i686'}}
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: tools
           path: tools
@@ -213,7 +216,7 @@ jobs:
           echo "${{ env.release_name }}"
           echo "${{ env.release_pre }}"
       - name: Download MinGW binaries and data
-        uses: actions/download-artifact@v2
+        uses: actions/download-artifact@v4
       - name: Generate .pdb files
         if: ${{ env.release_tag != '' }}
         run: |

ANTI_TROLL.md

@@ -0,0 +1,40 @@
+## Info on experimental anti-troll system
+If activated, a timer is kept for all players. System can be activated in xml config or in the lobby with command:
+\admin troll [0,1]
+
+Timer is increased by the amount of time when
+* a player drives in the wrong way
+* a player moves below a given speed (troll-max-stop-speed)
+
+Timer is not increased when the player is hit or rescued (during animation).
+
+It is decreased (not below 0 obviously) when a player drives in correct direction with at least given speed (troll-min-normal-speed).
+
+If a player's timer exceeds the warning level (troll-warning-time), they get a warning (troll-warn-message). After that the timer is reset.
+If a player got a warning and their timer exceeds the kick level (troll-kick-time), they get kicked.
+Warnings and Kicks are logged.
+
+Config can be controlled in xml file like this:
+
+    <!-- Set values for anti-troll system -->
+    <!-- If true, use anti troll system
+         This can also be controlled with server command:
+         \admin troll [0,1] -->
+    <use-anti-troll-system value="true" />
+    <!-- Warn string to show to player -->
+    <troll-warn-message value="WARNING: You troll, you get kicked !!" />
+    <!-- Warn player that drives backwards or stopps for given time -->
+    <troll-warning-time value="7.0" />
+    <!-- Kick player that drives backwards or stopps for given time -->
+    <troll-kick-time value="10.0" />
+    <!-- Minimum speed in correct direction to decrease wrong-way timer -->
+    <troll-min-normal-speed value="12.0" />
+    <!-- A player going slower than this is considered stopping -->
+    <troll-max-stop-speed value="5.0" />
+
+### Things to note
+* The system can be fooled of course, but it should be a lot harder to troll. Testing would be necessary. However, when I set up a test server, most players coming by just wanted to play normally...
+* The system should not warn or kick weak players who get lost or stuck on obstacles (too quickly). The current configuration values are most probably not yet perfect.
+* Players should probably be informed about the system, because waiting for others (like some pros do when giving weaker players some advice or driving lessons) would be punished, so the system should not be activated in those cases.
+* If a player presses UP-key early, the timer is increased during time punishment at the beginning of the race (1 sec). I don't know how to find out if a player is in that state.
+* **There may still be bugs** (of course)... ;)