Skip to content

Commit

Permalink
feat: use empty string for empty value
Browse files Browse the repository at this point in the history
  • Loading branch information
dvdmlln committed Apr 23, 2024
1 parent 4d27ab8 commit ac4d1f1
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
4 changes: 2 additions & 2 deletions Classes/Service/DatabaseService.php
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ private function formatFilterValues(array $rows, string $tableName, array $forei
} else {
$data['label'][] = $value
? $value
: LocalizationUtility::translate('emptyValue', 'rmnd_extbase');
: '';
$data['value'][$fieldName] = $value;
}
}
Expand All @@ -355,7 +355,7 @@ private function formatFilterValues(array $rows, string $tableName, array $forei
$value = $foreignTableRow['uid'] ?? '';
$label = $value
? $this->getRecordTitle($table, $foreignTableRow)
: LocalizationUtility::translate('emptyValue', 'rmnd_extbase');
: '';
$data['label'][] = $label;
$data['value'][$foreignTables[$table]] = $value;
unset($data['foreignTableRows']);
Expand Down
3 changes: 0 additions & 3 deletions Resources/Private/Language/de.locallang.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@
<trans-unit id="detail.record">
<target>Datensatz</target>
</trans-unit>
<trans-unit id="emptyValue">
<target>(Wert nicht gesetzt)</target>
</trans-unit>
<trans-unit id="filters.conjunction">
<target>Verknüpfungs-Modus</target>
</trans-unit>
Expand Down
3 changes: 0 additions & 3 deletions Resources/Private/Language/locallang.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@
<trans-unit id="detail.record">
<source>Record</source>
</trans-unit>
<trans-unit id="emptyValue">
<source>(Value not set)</source>
</trans-unit>
<trans-unit id="filters.conjunction">
<source>Conjunction Mode</source>
</trans-unit>
Expand Down

0 comments on commit ac4d1f1

Please sign in to comment.