Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecations for future flags #10126

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Add deprecations for future flags #10126

merged 4 commits into from
Oct 18, 2024

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Oct 16, 2024

No description provided.

Copy link

changeset-bot bot commented Oct 16, 2024

🦋 Changeset detected

Latest commit: 3cdb7eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Minor
create-remix Minor
remix Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit 984875d into dev Oct 18, 2024
6 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/deprecations branch October 18, 2024 14:17
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Oct 18, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

🤖 Hello there,

We just published version 2.14.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Nov 8, 2024

🤖 Hello there,

We just published version 2.14.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Nov 8, 2024
@Colin23 Colin23 mentioned this pull request Nov 10, 2024
18 tasks
@wouterds
Copy link

wouterds commented Nov 12, 2024

How does the deprecation of json() work in combination with

⚠️ REMIX FUTURE CHANGE: Externally-accessed resource routes will no longer be able to return raw JavaScript objects or null in React Router v7 when Single Fetch becomes the default. You can prepare for this change at your convenience by wrapping the data returned from your action function in the routes/users route with json(). For instructions on making this change, see https://remix.run/docs/en/v2.13.1/guides/single-fetch#resource-routes

@tmcw
Copy link
Contributor

tmcw commented Nov 12, 2024

There's quite a lot of documentation that still includes the json() method - the documentation for loader itself uses json(), as well as the tutorials. Folks who start from those directions will get warnings from Remix, which is not a very good onboarding experience.

@jshaver-emsi
Copy link

There's quite a lot of documentation that still includes the json() method ... Folks who start from those directions will get warnings from Remix, which is not a very good onboarding experience.

Not to mention there is nothing I can find pointing me to what I should do instead? It would be nice to also have the deprecation message point us to an alternative.

@danielvanc
Copy link

There's quite a lot of documentation that still includes the json() method ... Folks who start from those directions will get warnings from Remix, which is not a very good onboarding experience.

Not to mention there is nothing I can find pointing me to what I should do instead? It would be nice to also have the deprecation message point us to an alternative.

Yeah i agree. it should at least show examples of links to pages like these:
https://reactrouter.com/dev/start/framework/data-loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants