Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-dev/cli/migrate): process named exports in convert-to-javascript migration #4071

Conversation

MichaelDeBoey
Copy link
Member

Follow-up of #4030


This will fail on Windows because of facebook/jscodeshift#520, benjamn/recast#1170 & benjamn/ast-types#814

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2022

🦋 Changeset detected

Latest commit: eec218e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the base branch from main to dev August 25, 2022 18:16
@MichaelDeBoey MichaelDeBoey force-pushed the process-named-exports-in-convert-to-javascript-migration branch 2 times, most recently from 4e7ea03 to 1a336c8 Compare August 28, 2022 14:29
@MichaelDeBoey MichaelDeBoey force-pushed the process-named-exports-in-convert-to-javascript-migration branch from 1a336c8 to 69ee684 Compare September 3, 2022 16:38
@MichaelDeBoey MichaelDeBoey force-pushed the process-named-exports-in-convert-to-javascript-migration branch 4 times, most recently from 06206f3 to c42d6a8 Compare September 21, 2022 23:28
@MichaelDeBoey MichaelDeBoey force-pushed the process-named-exports-in-convert-to-javascript-migration branch 2 times, most recently from b153619 to def3ce8 Compare October 20, 2022 20:49
@MichaelDeBoey MichaelDeBoey force-pushed the process-named-exports-in-convert-to-javascript-migration branch 2 times, most recently from 52c0796 to 85514c6 Compare November 10, 2022 13:33
@MichaelDeBoey MichaelDeBoey force-pushed the process-named-exports-in-convert-to-javascript-migration branch from 85514c6 to 16be785 Compare November 19, 2022 22:12
@MichaelDeBoey MichaelDeBoey force-pushed the process-named-exports-in-convert-to-javascript-migration branch 4 times, most recently from 42c55b9 to 353e686 Compare December 7, 2022 20:02
@MichaelDeBoey MichaelDeBoey force-pushed the process-named-exports-in-convert-to-javascript-migration branch from 353e686 to 8146040 Compare December 8, 2022 02:45
@MichaelDeBoey MichaelDeBoey force-pushed the process-named-exports-in-convert-to-javascript-migration branch from 8146040 to af40d04 Compare December 21, 2022 18:41
@MichaelDeBoey MichaelDeBoey force-pushed the process-named-exports-in-convert-to-javascript-migration branch from af40d04 to cbbafff Compare January 18, 2023 16:11
@MichaelDeBoey MichaelDeBoey force-pushed the process-named-exports-in-convert-to-javascript-migration branch from cbbafff to eec218e Compare January 21, 2023 14:23
@pcattori
Copy link
Contributor

Superceded by #5163

@pcattori pcattori closed this Jan 21, 2023
@MichaelDeBoey MichaelDeBoey deleted the process-named-exports-in-convert-to-javascript-migration branch January 22, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants