Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

templates: ignore metafile.* files #7177

Merged
merged 1 commit into from
Aug 23, 2023
Merged

templates: ignore metafile.* files #7177

merged 1 commit into from
Aug 23, 2023

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Aug 15, 2023 •
edited
Loading

I originally just wanted to ignore the metafile.* files, but since the entire build directory is generated I figured it would be better to ignore it entirely 🤷‍♂️

Supersedes #7090

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9ad03aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 15, 2023
Closed
1 task
pmbanugo
pmbanugo reviewed Aug 15, 2023
View reviewed changes
templates/cloudflare-pages/.gitignore Outdated
node_modules

/.cache
/functions/\[\[path\]\].js
/functions/\[\[path\]\].js.map
/functions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think this is a good option because it’ll ignore any Pages function that one adds to their project.

I think we can just ignore the necessary Remix generated files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default there are no other functions except the generated ones

People can also always unignore certain files if they want to

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should try to target only the Remix-generated functions in the gitignore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcattori I assume only if we by default choose for another folder than build (which is the default build folder)?

lpsinger
lpsinger suggested changes Aug 16, 2023
View reviewed changes
templates/arc/.gitignore Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey force-pushed the ignore-metafiles-in-templates branch 5 times, most recently from 3f68c0e to 7489844 Compare August 22, 2023 20:21
@MichaelDeBoey MichaelDeBoey changed the title templates: ignore entire build directory templates: ignore metafile.* files Aug 22, 2023
@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 22, 2023
Closed
pmbanugo
pmbanugo approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@pmbanugo pmbanugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@pcattori pcattori merged commit 5fbc57f into remix-run:main Aug 23, 2023
9 checks passed
@MichaelDeBoey MichaelDeBoey deleted the ignore-metafiles-in-templates branch August 23, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmbanugo pmbanugo pmbanugo approved these changes

@pcattori pcattori pcattori approved these changes

@lpsinger lpsinger lpsinger approved these changes

@machour machour Awaiting requested review from machour

@markdalgleish markdalgleish Awaiting requested review from markdalgleish

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

Assignees

@ryanflorence ryanflorence

Labels
CLA Signed template:architect template:cloudflare-pages template:express template:netlify template:vercel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MichaelDeBoey @lpsinger @pcattori @pmbanugo @ryanflorence