Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(templates/remix): esm by default #7202

Merged
merged 1 commit into from
Aug 21, 2023
Merged

chore(templates/remix): esm by default #7202

merged 1 commit into from
Aug 21, 2023

Conversation

pcattori
Copy link
Contributor

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: fdfb66c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MichaelDeBoey
MichaelDeBoey approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we cherry-pick this on main as wel for the TS template?

@pcattori pcattori merged commit e000200 into dev Aug 21, 2023
9 checks passed
@pcattori pcattori deleted the pedro/remix-serve-esm branch August 21, 2023 17:24
@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 21, 2023
Closed
@KarelVerschraegen KarelVerschraegen mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-ebey jacob-ebey jacob-ebey approved these changes

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
CLA Signed template:remix template:remix-javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcattori @MichaelDeBoey @jacob-ebey