-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(serve): manual mode integration #7231
Conversation
🦋 Changeset detectedLatest commit: 2990c95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3e9f8fc
to
8072831
Compare
@@ -4,7 +4,7 @@ | |||
"type": "module", | |||
"scripts": { | |||
"build": "remix build", | |||
"dev": "remix dev", | |||
"dev": "remix dev --manual", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we default to manual if no command is provided now that the serve CLI that will be used does cache busting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but then we'd need a way to opt out of --manual
which we don't currently have.
For v2, Michael and I agreed that we probably want a lever like --mode=watch
, --mode=live-reload
, --mode=hot
or something like that instead of --manual
. naming TBD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just mean:
if (!userProvidedCommand) {
manual = true
}
for the specific case of "no command provided, use remix-serve as it expects to be used"
2beb21f
to
c3f8b81
Compare
c3f8b81
to
2990c95
Compare
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Testing Strategy:
Tested locally via
LOCAL_BUILD_DIRECTORY
TODO
import