Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serve): manual mode integration #7231

Merged
merged 11 commits into from
Aug 25, 2023
Merged

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Aug 22, 2023

Testing Strategy:

Tested locally via LOCAL_BUILD_DIRECTORY

TODO

  • Windows: URL file path for import
  • kill app server and esbuild after tests run

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2023

🦋 Changeset detected

Latest commit: 2990c95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/serve Major
@remix-run/dev Major
create-remix Major
remix Major
@remix-run/architect Major
@remix-run/cloudflare Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
@remix-run/css-bundle Major
@remix-run/deno Major
@remix-run/eslint-config Major
@remix-run/express Major
@remix-run/node Major
@remix-run/react Major
@remix-run/server-runtime Major
@remix-run/testing Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/remix-serve/cli.ts Show resolved Hide resolved
@@ -4,7 +4,7 @@
"type": "module",
"scripts": {
"build": "remix build",
"dev": "remix dev",
"dev": "remix dev --manual",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we default to manual if no command is provided now that the serve CLI that will be used does cache busting?

Copy link
Contributor Author

@pcattori pcattori Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but then we'd need a way to opt out of --manual which we don't currently have.

For v2, Michael and I agreed that we probably want a lever like --mode=watch, --mode=live-reload, --mode=hot or something like that instead of --manual. naming TBD

Copy link
Member

@jacob-ebey jacob-ebey Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just mean:

if (!userProvidedCommand) {
  manual = true
}

for the specific case of "no command provided, use remix-serve as it expects to be used"

@pcattori pcattori force-pushed the pedro/remix-serve-manual-mode branch from c3f8b81 to 2990c95 Compare August 25, 2023 15:53
@pcattori pcattori merged commit e12840b into dev Aug 25, 2023
9 checks passed
@pcattori pcattori deleted the pedro/remix-serve-manual-mode branch August 25, 2023 16:20
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Aug 25, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-f77588e-20230826 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@MichaelDeBoey MichaelDeBoey added BREAKING CHANGE This change will require a major version bump v2 Issues related to v2 apis labels Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon BREAKING CHANGE This change will require a major version bump CLA Signed package:serve template:remix template:remix-javascript v2 Issues related to v2 apis
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants