Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/fix Single Fetch revalidation behavior #9938

Merged
merged 8 commits into from
Sep 5, 2024

Conversation

brophdawg11
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 99a0e5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/react Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/node Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/architect Patch
@remix-run/express Patch
@remix-run/serve Patch
create-remix Patch
remix Patch
@remix-run/css-bundle Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -416,7 +416,7 @@ test.describe("single fetch", () => {
await waitForAndAssert(
page,
app,
"#child-error",
"#parent-error",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the entire single fetch call fails we'll report this error for all the routes so it'll naturally "bubble" to the parent

@brophdawg11 brophdawg11 merged commit 5cfd3c3 into dev Sep 5, 2024
9 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/single-fetch-revalidation branch September 5, 2024 13:54
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

🤖 Hello there,

We just published version 2.12.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Sep 9, 2024

🤖 Hello there,

We just published version 2.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant