make type validation checks easier to read

remoteoss · Feb 4, 2025 · c96207b · c96207b
1 parent d3316af
commit c96207b
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/next/src/validation/schema.ts b/next/src/validation/schema.ts
@@ -58,8 +58,18 @@ function validateType(value: SchemaValue, schema: JsfSchema): ValidationError[]
   const schemaType = getSchemaType(schema)
   const valueType = value === undefined ? 'undefined' : typeof value
 
-  if (Array.isArray(schemaType) ? !schemaType.includes(valueType) : valueType !== schemaType) {
-    return [{ path: [], validation: 'type', message: `should be ${schemaType}` }]
+  const hasTypeMismatch = Array.isArray(schemaType)
+    ? !schemaType.includes(valueType)
+    : valueType !== schemaType
+
+  if (hasTypeMismatch) {
+    return [{
+      path: [],
+      validation: 'type',
+      message: `should be ${Array.isArray(schemaType)
+        ? schemaType.join(' | ')
+        : schemaType}`,
+    }]
   }
 
   return []