Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVXP-2570: feat(next): Add custom order #119

Merged
merged 2 commits into from
Feb 6, 2025
Merged

DEVXP-2570: feat(next): Add custom order #119

merged 2 commits into from
Feb 6, 2025

Conversation

thien-remote
Copy link
Collaborator

@thien-remote thien-remote commented Feb 5, 2025

This PR adds support for custom order in the Next version. See:

There are actually 2 parts actually, reflecting in the 2 commits:

  • 12336de adds the basic support for "fields" (docs), especially the recursive support for "object" type.
  • 018b0b8 adds the actual custom order feature.

Do tell if you want me to split the PR as the commits 👋

Copy link
Collaborator

@lukad lukad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@dragidavid
Copy link
Collaborator

Happy to approve this since it seems that it covers the base cases. We can always adjust if needed.

@thien-remote thien-remote merged commit 07c7ea1 into main Feb 6, 2025
3 checks passed
@thien-remote thien-remote deleted the DEVXP-2570 branch February 6, 2025 09:06
next/src/form.ts Show resolved Hide resolved
next/src/field/object.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants