Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVXP-2544: feat(next): add anyOf validation #120

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

dragidavid
Copy link
Collaborator

@dragidavid dragidavid commented Feb 5, 2025

This PR add handling for the anyOf keyword. Also includes the tests from the official test suite as well as a test with a demo schema.

@dragidavid dragidavid marked this pull request as ready for review February 5, 2025 17:21
@dragidavid dragidavid changed the title feat(next): add anyOf validation DEVXP-2544: feat(next): add anyOf validation Feb 5, 2025
thien-remote
thien-remote previously approved these changes Feb 6, 2025
Copy link
Collaborator

@thien-remote thien-remote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have quite many comments, but none are blocking, so ✅

next/src/types.ts Show resolved Hide resolved
next/src/validation/anyOf.ts Outdated Show resolved Hide resolved
next/src/validation/anyOf.ts Show resolved Hide resolved
next/src/validation/anyOf.ts Outdated Show resolved Hide resolved
next/src/validation/anyOf.ts Show resolved Hide resolved
next/src/validation/schema.ts Show resolved Hide resolved
next/test/validation/anyOf.test.ts Show resolved Hide resolved
next/test/validation/anyOf.test.ts Outdated Show resolved Hide resolved
next/test/validation/anyOf.test.ts Show resolved Hide resolved
next/test/validation/anyOf.test.ts Outdated Show resolved Hide resolved
@dragidavid dragidavid requested a review from sandrina-p February 6, 2025 13:52
Copy link
Collaborator

@thien-remote thien-remote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feedback last round is all addressed, and there's 8308f6b to add a todo, so it's good to go for me ✅

Feel free to veto if you have a strong opinion 😄

@dragidavid dragidavid merged commit b15c2b5 into main Feb 7, 2025
3 checks passed
@dragidavid dragidavid deleted the devxp-2544-implement-the-anyof-keyword branch February 7, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants