-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fieldset): Support customProperties with sub-fields clashing with reserved words. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeynimu
changed the title
fix: update fieldset customization
fix(fieldset field customization): Update subfield(s) customProperties path
Jan 29, 2024
remotecom
force-pushed
the
joe/fieldset-custom-properties
branch
from
January 29, 2024 18:08
8c5c56b
to
ca8be82
Compare
sandrina-p
requested changes
Jan 29, 2024
sandrina-p
reviewed
Jan 30, 2024
joeynimu
changed the title
fix(fieldset field customization): Update subfield(s) customProperties path
fix(fieldset): Support customProperties with sub-fields clashing with reserved words.
Jan 30, 2024
This is all good my side from testing it internally with Remote. |
sandrina-p
reviewed
Jan 31, 2024
sandrina-p
previously approved these changes
Feb 1, 2024
brennj
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets goo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug(what)
Passing the below
jsfOption
config tocreateHeadlessForm
, we get an error;The solution
This PR updates the path used for getting customizing (jsfOptions) of the fields inside a fieldset. Before this was been read from the parent field (fieldset) but now we read them within the
customProperties
of the parent fieldAnd so the failing jsfOption example above becomes;
It also updates test cases to read the customisation from the new path.