fix(modify): Support x-jsf shorthands in all methods, fix TS declarations; mark createHeadlessForm config.customProperties as deprecated #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- config.create should be just an object, not supporting callback fn. - config.fields callback function should have 1 param (fieldAttrs), not 2. (fieldName, fieldAttrs)
danielcardoso5
approved these changes
Jul 29, 2024
sandrina-p
changed the title
sandrina-p
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has multiple small fixes after #81 and #84
x-jsf-shorthands inconfig.allFields— Added tests for all needed methods (andconfig.fieldsandconfig.create).config.fieldsvalue as callback function should have 1 param(fieldAttrs), not 2.(fieldName, fieldAttrs)config.createvalue should be an object only, it cannot be a callback fn.config.customPropertiesas deprecated in code, tests, and TS declarations.