Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test multi-platfrom docker image #666

Closed
wants to merge 4 commits into from
Closed

Test multi-platfrom docker image #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd3e521
Build a truly multi platform docker image
podhrmic Oct 25, 2024
3484b15
Temporarily disable the cron job
podhrmic Oct 28, 2024
51bb8c7
Attemp to trigger the docker build
podhrmic Oct 28, 2024
2b3d7a6
Fix the platform tags
podhrmic Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 35 additions & 6 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: docker

on:
schedule:
- cron: '30 18 * * *'
# Temporary - change back to schedule once it is confirmed to work
pull_request:
# schedule:
# - cron: '30 18 * * *'

env:
CERBERUS_IMAGE_ID: ghcr.io/rems-project/cerberus/cn:release
Expand All @@ -20,7 +22,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
platform: [linux/amd64, linux/arm64]
platform: [linux-amd64, linux-arm64]
permissions:
packages: write
contents: read
Expand All @@ -44,7 +46,34 @@ jobs:
run: |
echo "Building ${{env.CERBERUS_IMAGE_ID}}"
PLATFORM=${{ matrix.platform }} make -f Makefile_docker release_cn
docker tag cn:release ${{env.CERBERUS_IMAGE_ID}}

docker tag cn:release ${{env.CERBERUS_IMAGE_ID}}-${{ matrix.platform }}
- name: Push the Docker image
run: docker push ${{env.CERBERUS_IMAGE_ID}}
run: docker push ${{env.CERBERUS_IMAGE_ID}}-${{ matrix.platform }}

combine-docker:
runs-on: docker:latest
needs: deploy-docker
permissions:
packages: write
contents: read
attestations: write
id-token: write
steps:
- uses: actions/checkout@v4

- name: Login to GitHub Container Registry
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Pull images
run: |
docker pull ${{env.CERBERUS_IMAGE_ID}}-linux-amd64
docker pull ${{env.CERBERUS_IMAGE_ID}}-linux-arm64
- name: Create manifest
run: |
docker manifest create ${{env.CERBERUS_IMAGE_ID}} ${{env.CERBERUS_IMAGE_ID}}-linux-amd64 ${{env.CERBERUS_IMAGE_ID}}-linux-arm64
docker manifest inspect ${{env.CERBERUS_IMAGE_ID}}
- name: Push the Docker image
run: docker manifest push ${{env.CERBERUS_IMAGE_ID}}
21 changes: 16 additions & 5 deletions Makefile_docker
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,33 @@
.PHONY: all release dev-env deps

PLATFORM ?= linux/amd64
# This is needed because docker tags can't have `/` in the name
PLATFORM ?= linux-amd64
ifeq ($(PLATFORM),linux-amd64)
DOCKER_PLATFORM=linux/amd64
else
ifeq ($(PLATFORM),linux-arm64)
DOCKER_PLATFORM=linux/arm64
else
$(error "Unknown platform!")
endif
endif

$(info Building for platform $(PLATFORM))

all:
@echo 'targets: deps|release|dev-env'

deps :
docker build --platform $(PLATFORM) --tag cerberus:deps -f Dockerfile.deps .
docker build --platform $(DOCKER_PLATFORM) --tag cerberus:deps -f Dockerfile.deps .

release: deps
docker build --platform $(PLATFORM) --tag cerberus:release -f Dockerfile.release .
docker build --platform $(DOCKER_PLATFORM) --tag cerberus:release -f Dockerfile.release .
@echo 'for example: docker run --volume `PWD`:/data/ cerberus:release cerberus tests/tcc/00_assignment.c --pp=core'

release_cn: deps
docker build --platform $(PLATFORM) --tag cn:release -f Dockerfile.release .
docker build --platform $(DOCKER_PLATFORM) --tag cn:release -f Dockerfile.release .
@echo 'for example: docker run --volume `PWD`:/data/ cn:release cerberus tests/tcc/00_assignment.c --pp=core'

dev-env: deps
docker build --platform $(PLATFORM) --tag cerberus:dev-env -f Dockerfile.dev-env .
docker build --platform $(DOCKER_PLATFORM) --tag cerberus:dev-env -f Dockerfile.dev-env .
@echo 'for example: docker run -ti --volume `PWD`:/home/user1/cerberus/ cerberus:dev-env'
Loading