Remove the need for the HAVE_COVERAGE check #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alasdair
force-pushed
the
coverage_rts2
branch
2 times, most recently
from
bde999f to
f4bf5e3
Compare
Have the compiler generate a hook function that is either NULL or calls the coverage function the runtime wants to use, depending on whether coverage is enabled or not.
There was a problem hiding this comment.
This looks quite reasonable to me. @elliotb-lowrisc can you test this with your setup?
|
Nice fix. It works for me locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the compiler generate a hook function that is either NULL or calls the coverage function the runtime wants to use, depending on whether coverage is enabled or not.