Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lean: handling foreach Loops #990

Merged
merged 10 commits into from
Feb 13, 2025
Merged

Lean: handling foreach Loops #990

merged 10 commits into from
Feb 13, 2025

Conversation

lfrenot
Copy link
Collaborator

@lfrenot lfrenot commented Feb 13, 2025

No description provided.

@ineol ineol added the Lean Issues with Sail to Lean translation label Feb 13, 2025
Copy link
Collaborator

@ineol ineol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Comment on lines 260 to 261
have h : step > 0 := by omega
let range := Std.Range.mk from' to step h
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
have h : step > 0 := by omega
let range := Std.Range.mk from' to step h
let range := Std.Range.mk from' to step (by omega)

slighly lighter

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 274 to 275
have h : step > 0 := by omega
let range := Std.Range.mk from' to step h
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done as well

Copy link

Test Results

   12 files  ±0     26 suites  ±0   0s ⏱️ ±0s
  768 tests +1    768 ✅ +1  0 💤 ±0  0 ❌ ±0 
2 714 runs  +1  2 714 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit e1e14b4. ± Comparison against base commit fb7249f.

@bacam bacam merged commit f2432d8 into rems-project:sail2 Feb 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lean Issues with Sail to Lean translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants