Disable match_bv for now since it's breaking the RISC-V model #993
+133
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 12 files ±0 26 suites ±0 0s ⏱️ ±0s For more details on these errors, see this check. Results for commit 69b3f3f. ± Comparison against base commit 0d53955. ♻️ This comment has been updated with latest results. |
|
Merged as #1000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are pattern matches with conditional guards (like in
write_CSRandwrite_CSR2), rewriting will produce incompatible nested pattern matches and blow up the produced AST. This arises in the RISC-V model, so we are disabling match_bv for now.FYI @arthur-adjedj