Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces all profile_image_url with profile_image_url_https. #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ For example, this repository includes some test data in the <code>test</code> di

Within the files the result is being passed to a predefined callback called <code>callback</code>, i.e.

<strong>callback</strong>({"results":[{"profile_image_url":"http://a3.twimg.com/profile_images/.....
<strong>callback</strong>({"results":[{"profile_image_url_https":"https://a3.twimg.com/profile_images/.....

Note that the number in the filename match the page numbers, so this can be a variable in our debug URL.

Expand Down
2 changes: 1 addition & 1 deletion test/test-data/list1.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/test-data/list2.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/test-data/list3.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/test-data/list4.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/test-data/search1.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/test-data/search2.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/test-data/search3.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/test-data/search4.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/test-data/search5.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/test-data/search6.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/test-data/search7.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/test-data/search8.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion test/test-data/search9.json

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions twitterlib.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// twitterlib.js (c) 2011 Remy Sharp
// @version 1.0.9 / Sun Feb 19 23:05:25 2012 +0000
// @version 1.1.4 / Fri Feb 23 10:22:31 2018 -0600
// MIT license: http://rem.mit-license.org
(function (global) {
var twitterlib = {};
Expand Down Expand Up @@ -368,7 +368,7 @@
// based on twitter.com list of tweets, most common format for tweets
function render(tweet) {
var html = '<li><div class="tweet">';
html += '<div class="vcard"><a href="http://twitter.com/' + tweet.user.screen_name + '" class="url"><img style="height: 48px; width: 48px;" alt="' + tweet.user.name + '" class="photo fn" height="48" src="' + tweet.user.profile_image_url + '" width="48" /></a></div>';
html += '<div class="vcard"><a href="http://twitter.com/' + tweet.user.screen_name + '" class="url"><img style="height: 48px; width: 48px;" alt="' + tweet.user.name + '" class="photo fn" height="48" src="' + tweet.user.profile_image_url_https + '" width="48" /></a></div>';
html += '<div class="hentry"><strong><a href="http://twitter.com/';
html += tweet.user.screen_name + '" ';
html += 'title="' + tweet.user.name + '">' + tweet.user.screen_name + '</a></strong> ';
Expand Down Expand Up @@ -417,7 +417,7 @@

// fix the user prop to match "normal" API calls
while (i--) {
tweets[i].user = { id: tweets[i].from_user_id, screen_name: tweets[i].from_user, profile_image_url: tweets[i].profile_image_url };
tweets[i].user = { id: tweets[i].from_user_id, screen_name: tweets[i].from_user, profile_image_url_https: tweets[i].profile_image_url_https };
tweets[i].source = twitterlib.ify.entities(tweets[i].source);

// fix created_at
Expand Down Expand Up @@ -589,7 +589,7 @@
}

twitterlib = {
version: '1.0.9', //@version 1.0.9 / Sun Feb 19 23:05:25 2012 +0000
version: '1.1.4', //@version 1.1.4 / Fri Feb 23 10:22:31 2018 -0600
// search is an exception case
custom: custom,
getUrl: getUrl,
Expand Down
5 changes: 1 addition & 4 deletions twitterlib.min.js

Large diffs are not rendered by default.