Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pidgin-windev for 2.12.0 and security #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update pidgin-windev for 2.12.0 and security #1

wants to merge 2 commits into from

Conversation

genodeftest
Copy link

No description provided.

@genodeftest
Use HTTPS where possible
50fbe55 
Use HTTPS URLs where available, check certificates if possible. These
changes improve protection against man-in-the-middle-attacks.
@genodeftest
Update for 2.12.0 and dependencies
208f9ad 
Binutils 2.23.1 is not available any more, use 2.28 instead.
No reason found why one should use gcc-core 4.4.0 with gcc 4.7.2, so
using pure 4.7.2 which comes with gcc-core bundled.
Update Gtk+ to the version shipped with 2.12.0 windows installer.
@shiitake
Copy link

I had some issues with running this script in Cygwin

$ ./pidgin-windev.sh pidgin-devel
./pidgin-windev.sh: line 2: $'\r': command not found
./pidgin-windev.sh: line 7: $'\r': command not found

It looks like this is related to some of issues with the line endings. It can be resolved by running dos2unix or by running sed -i 's/\r$//' pidgin-windev.sh (which is what I had to do since I didn't have dos2unix installed)

@genodeftest
Copy link
Author

@shiitake : I cannot reproduce your issue on Linux. After and running dos2unix or the sed command you provided above, there are no changes for me to commit to git, so I'm unable to fix this issue. Anyway, since my changes do not touch either lines, I think you should open a new issue. It looks like the git config is wrong. As far as I remember, there are some options to fix line endings in git. You might want to consult the manual. I don't know whether those changes are specific to your git config (i.e. global git config) or this repo git config.

@SvenLudwig202
Copy link

I can confirm: no problems using genodeftest's patch on current cygwin (as of today)

@shiitake
Copy link

@genodeftest thanks for the quick reply. sorry for invading your pull request. Since it appears that this repo hasn't been touched in a few years (except for your PR) I figured this might be the quickest way to grab someone's attention.

@genodeftest
Copy link
Author

@shiitake : No problem and thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiitake shiitake shiitake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@genodeftest @shiitake @SvenLudwig202