app: assets: set 1000-task limit for transfer history fetch #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sehyunc
approved these changes
Jan 8, 2025
akirillo
force-pushed
the
andrew/higher-task-history-len
branch
from
09851eb to
09d902f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages the changes in renegade-fi/typescript-sdk#149 to set a 1000-task limit for the task history fetch used to display transfer history. Using this large constant is a stopgap solution until historical state is fully integrated, which will support pagination at the API layer.
Testing
This was tested by running a local frontend against the mainnet stack, where I asserted that I was able to fetch transfer history from further back for my wallet.