ga: upgrade: check for rollback #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirillo
force-pushed
the
andrew/upgrade-failed-on-rollback
branch
from
fdaae7b to
7795bf1
Compare
akirillo
commented
Feb 8, 2024
joeykraut
approved these changes
Feb 9, 2024
akirillo
force-pushed
the
andrew/upgrade-failed-on-rollback
branch
from
7795bf1 to
137f5a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a final step to the upgrade action to check if the ECS deployment rolled back. The
amazon-ecs-deploy-task-definitionaction exposes no way to check this. It simply waits for the service to reach a steady state, which it will also do if it rolled back successfully.Thus, this step checks if the task definition used in the most recent deployment (which may be a rollback) matches the newly created task definition. If not, a rollback must have occurred, and we error.
I have tested this on the staging branch with an image that fails trivially and asserted that a rollback is caught.