wasm: sign wallet comm using correct signing key #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehyunc
force-pushed
the
sehyun/fix-sign-comm
branch
from
540a0c8 to
8ea513f
Compare
sehyunc
force-pushed
the
sehyun/fix-sign-comm
branch
from
8ea513f to
2187ea7
Compare
akirillo
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
why don't we do a key rotation in update_order? and if we should be doing this, we'd also need to replicate these changes to use the proper old signing key there
There was a problem hiding this comment.
It was omitted from the original external key implementation PR since no external wallets will use that task. Currently on the backlog to bring it up to speed with the rest of the tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes an issue where the rotated keychain was used to derive a signing key that was resulting in invalid wallet update signatures. To do so, the correct signing key is returned by
handle_keychain_rotation, and is used as the signing key for internal wallets.Testing