Fix ESLint problems

.eslintignore

@@ -0,0 +1 @@
+packages/*/test

.eslintrc

@@ -5,6 +5,15 @@
   "rules": {
     "@typescript-eslint/indent": "off",
     "@typescript-eslint/explicit-function-return-type": "off",
-    "import/no-extraneous-dependencies": ["error", {"devDependencies": true}]
+    "import/no-extraneous-dependencies": ["error", {"devDependencies": true}],
+    "no-restricted-syntax": "off",
+    "@typescript-eslint/interface-name-prefix": "off",
+    "import/no-unresolved": "off",
+    "import/no-dynamic-require": "off",
+    "global-require": "off",
+    "no-use-before-define": ["error", "nofunc"],
+    "@typescript-eslint/no-use-before-define": ["error", "nofunc"],
+    "no-continue": "off",
+    "prefer-template": "off"
   }
 }

package.json

@@ -12,6 +12,7 @@
     "*.ts": [
       "npx import-sort-cli --write",
       "prettier --write",
+      "eslint --fix",
       "git add"
     ],
     "*.{json,md}": [

packages/atom-import-sort/.eslintrc

@@ -0,0 +1,6 @@
+{
+  "extends": "../../.eslintrc",
+  "globals": {
+    "atom": false
+  }
+}

packages/atom-import-sort/src/index.d.ts

@@ -1,4 +1,4 @@
 declare module "loophole" {
-  export function allowUnsafeEval(f: () => any);
-  export function allowUnsafeNewFunction(f: () => any);
+  export function allowUnsafeEval(f: () => unknown);
+  export function allowUnsafeNewFunction(f: () => unknown);
 }

packages/atom-import-sort/src/index.ts

@@ -1,13 +1,14 @@
 import {dirname, extname} from "path";
 
-// tslint:disable-next-line:no-implicit-dependencies
-import {CompositeDisposable, TextEditor} from "atom";
+import {CompositeDisposable, TextEditor} from "atom"; // eslint-disable-line
 import sortImports, {ICodeChange} from "import-sort";
 import {getConfig} from "import-sort-config";
 import {allowUnsafeEval, allowUnsafeNewFunction} from "loophole";
 
+// eslint-disable-next-line
 export class Plugin {
   public bufferWillSaveDisposables;
+
   public editorObserverDisposable;
 
   public config = {
@@ -20,8 +21,8 @@ export class Plugin {
     },
   };
 
-  public activate(state) {
-    (atom.config as any).observe(
+  public activate() {
+    atom.config.observe(
       "atom-import-sort.sortOnSave",
       (sortOnSave: boolean) => {
         if (sortOnSave) {
@@ -69,6 +70,7 @@ export class Plugin {
     }
   }
 
+  // eslint-disable-next-line
   private sortEditor(editor, notifyErrors = false) {
     const scopeDescriptor = editor.getRootScopeDescriptor();
 
@@ -102,7 +104,7 @@ export class Plugin {
         extension = ".ts";
       }
 
-      directory = (atom.project as any).getPaths()[0];
+      [directory] = atom.project.getPaths();
     }
 
     if (!extension) {
@@ -143,17 +145,17 @@ export class Plugin {
       const cursor = editor.getCursorBufferPosition();
       const unsorted = editor.getText();
 
-      let changes: Array<ICodeChange>;
+      let changes: ICodeChange[];
 
       allowUnsafeNewFunction(() => {
         allowUnsafeEval(() => {
-          changes = sortImports(
+          ({changes} = sortImports(
             unsorted,
-            parser!,
-            style!,
+            parser,
+            style,
             path,
             rawConfig.options,
-          ).changes;
+          ));
         });
       });
 

packages/import-sort-cli/.eslintrc

@@ -0,0 +1,6 @@
+{
+  "extends": "../../.eslintrc",
+  "rules": {
+    "no-console": "off"
+  }
+}

packages/import-sort-cli/src/index.ts

@@ -35,7 +35,7 @@ Usage: import-sort [OPTION]... [FILE/GLOB]...
   .help()
   .alias("help", "h");
 
-const argv = yargs.argv;
+const {argv} = yargs;
 
 let filePatterns = argv._;
 
@@ -92,8 +92,8 @@ for (const filePath of filePaths) {
   try {
     sortResult = sortImports(
       unsortedCode,
-      parser!,
-      style!,
+      parser,
+      style,
       filePath,
       rawConfig.options,
     );
@@ -102,7 +102,7 @@ for (const filePath of filePaths) {
     continue;
   }
 
-  const {code: sortedCode, changes} = sortResult!;
+  const {code: sortedCode, changes} = sortResult;
 
   const isDifferent = changes.length > 0;
 
@@ -126,21 +126,22 @@ function getAndCheckConfig(
 ): IResolvedConfig {
   const resolvedConfig = getConfig(extension, fileDirectory);
 
-  throwIf(!resolvedConfig, `No configuration found for file type ${extension}`);
+  if (!resolvedConfig) {
+    throw new Error(`No configuration found for file type ${extension}`);
+  }
 
-  const rawParser = resolvedConfig!.config.parser;
-  const rawStyle = resolvedConfig!.config.style;
+  const rawParser = resolvedConfig.config.parser;
+  const rawStyle = resolvedConfig.config.style;
 
   throwIf(!rawParser, `No parser defined for file type ${extension}`);
   throwIf(!rawStyle, `No style defined for file type ${extension}`);
 
-  const parser = resolvedConfig!.parser;
-  const style = resolvedConfig!.style;
+  const {parser, style} = resolvedConfig;
 
   throwIf(!parser, `Parser "${rawParser}" could not be resolved`);
   throwIf(!style, `Style "${rawStyle}" could not be resolved`);
 
-  return resolvedConfig!;
+  return resolvedConfig;
 }
 
 function handleFilePathError(filePath, e) {

packages/import-sort-config/src/index.ts

@@ -9,7 +9,7 @@ export interface IConfigByGlobs {
 export interface IConfig {
   parser?: string;
   style?: string;
-  options?: any;
+  options?: object;
 }
 
 export interface IResolvedConfig {
@@ -45,7 +45,7 @@ export function getConfig(
   const actualConfig = mergeConfigs([defaultConfig, packageConfig]);
 
   if (!actualConfig) {
-    return;
+    return undefined;
   }
 
   const resolvedConfig = resolveConfig(actualConfig, directory);
@@ -60,7 +60,7 @@ function getConfigFromDirectory(
   const packageConfigs = getAllConfigsFromDirectory(directory);
 
   if (!packageConfigs) {
-    return;
+    return undefined;
   }
 
   return getConfigForExtension(packageConfigs, extension);
@@ -70,14 +70,16 @@ function getConfigForExtension(
   configs: IConfigByGlobs,
   extension: string,
 ): IConfig | undefined {
-  const foundConfigs: Array<IConfig | undefined> = Object.keys(configs).map(
+  const foundConfigs: (IConfig | undefined)[] = Object.keys(configs).map(
     joinedGlobs => {
       const globs = joinedGlobs.split(",").map(rawGlob => rawGlob.trim());
       const config = configs[joinedGlobs];
 
       if (globs.some(glob => minimatch(extension, glob))) {
         return config;
       }
+
+      return undefined;
     },
   );
 
@@ -97,22 +99,24 @@ function getAllConfigsFromDirectory(
     const configsResult = configsLoader.searchSync(directory);
 
     if (!configsResult) {
-      return;
+      return undefined;
     }
 
     return configsResult.config;
   } catch (e) {
-    return;
+    // Do nothing…
   }
+
+  return undefined;
 }
 
 function mergeConfigs(
-  rawConfigs: Array<IConfig | undefined>,
+  rawConfigs: (IConfig | undefined)[],
 ): IConfig | undefined {
-  const configs = rawConfigs.filter(rawConfig => !!rawConfig) as Array<IConfig>;
+  const configs = rawConfigs.filter(rawConfig => !!rawConfig) as IConfig[];
 
   if (configs.length === 0) {
-    return;
+    return undefined;
   }
 
   return configs.reduce((previousConfig, currentConfig) => {
@@ -134,7 +138,7 @@ function mergeConfigs(
       config.options = currentConfig.options;
     }
 
-    return config!;
+    return config;
   });
 }
 
@@ -182,4 +186,6 @@ function resolveModule(module: string, directory?: string): string | undefined {
   if (defaultPath) {
     return defaultPath;
   }
+
+  return undefined;
 }