Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Simplify type inference for result type helpers #33576

Merged
merged 1 commit into from
Jan 11, 2025
Merged

refactor: Simplify type inference for result type helpers #33576

merged 1 commit into from
Jan 11, 2025
+21 −17

Conversation

zharinov
Copy link
Collaborator

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from viceice January 11, 2025 17:48
@viceice viceice added this pull request to the merge queue Jan 11, 2025
@viceice
Copy link
Member

viceice commented Jan 11, 2025

what about import { z } from "zod"; import instead of star import?

https://www.npmjs.com/package/zod#basic-usage

Merged via the queue into renovatebot:main with commit 4466ccd Jan 11, 2025
39 checks passed
@viceice viceice deleted the refactor/result-util-zod-inference branch January 11, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zharinov @viceice