Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The itemIconStyle property was declared in the wrong way. #156

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dnlsilva
Copy link

@dnlsilva dnlsilva commented Dec 4, 2019

When you check the ItemIcon.js file, you can see that in its properties there is one declared with the name itemIconStyle, but in the RowItem.js file the style property is declared, which makes the property declaration not working.

With this change by declaring:
Ex: styles={{ itemIconStyle: {width: 50, height: 50} }}
It is possible to see the changes.

TD;LR: itemIconStyle does not work as expected.

@renrizzolo
Copy link
Owner

Good catch, thanks.
Can you add the fix to RowSubItem as well?

@dnlsilva
Copy link
Author

dnlsilva commented Dec 5, 2019

Done.

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants