Fix: treat non-existant XML attributes correctly #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode omits the optional attribute in its XML model output if it is set to not-optional, but `NSPropertyDescription.optional` defaults to YES. To be on the safe side I decided to treat all Booleans the same. Currenlty only optional was affected, because it's the only attribute which default is YES. That should fix issue #286
|
Your fix also needs two lines changed in machine.swift.motemplate: - public var <$Attribute.name$>: NSNumber? + public var <$Attribute.name$>: NSNumber<$if Attribute.isOptional$>?<$endif$> ... - var <$Attribute.name$>: NSNumber? + var <$Attribute.name$>: NSNumber<$if Attribute.isOptional$>?<$endif$> |
|
We are declaring pull request and issue 0 now that 1.3 is out. If this is still an issue you'd like to see address with 1.30 and going forward, please open a new issue so we can start a fresh discussion. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode omits the optional attribute in its XML model output if
it is set to not-optional, but
NSPropertyDescription.optionaldefaults to
YES.To be on the safe side I decided to treat all Booleans the same.
Currenlty only
optionalwas affected, because it's the onlyattribute which default is
YES.That should fix issue #286