-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add tcp feature to hyper #77
Conversation
Prevents `executor must be set` panic when hyper with tcp enabled is not already in the dependencies of the project
Also hyper itself should be updated: #75 |
cc @HarryET because they are not watching the repo |
I'm no longer a member of the company so sadly my ability to merge the PR isn't there anymore. I'll ping someone there and see if they can review and/or take the repo back. \cc @chris13524 |
Thanks for the ping @HarryET! This repo wasn't being watched but now it is. @threema-donat can you rebase on #75 ? |
I would suggest to merge this first and then do a release (e.g. as version
|
@chris13524 Thank you for merging this! I realized that you have created the GitHub release for |
Yeh @threema-donat yes sorry, working on the publish. Need to transfer from original owner |
Prevents
executor must be set
panic when hyper with tcp enabled is not already in the dependencies of the project.Description
I suggest to release a new version once this is merged since a2 cannot work for anybody not having
hyper ^0.14
withtcp
feat enabled in the dependencies.Resolves #76
How Has This Been Tested?
Used this as a path dependency in this project
Due Dilligence