Make chains required & remove 0 chain config (#1553)

Co-authored-by: Sven <[email protected]>
reown-com · Dec 15, 2023 · 3cb12f8 · 3cb12f8 · vercel · Dec 15, 2023
1 parent 4959d48
commit 3cb12f8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/ethers/src/client.ts b/packages/ethers/src/client.ts
@@ -41,8 +41,8 @@ import type { CombinedProvider } from '@web3modal/scaffold-utils/ethers'
 // -- Types ---------------------------------------------------------------------
 export interface Web3ModalClientOptions extends Omit<LibraryOptions, 'defaultChain' | 'tokens'> {
   ethersConfig: ProviderType
+  chains: Chain[]
   siweConfig?: Web3ModalSIWEClient
-  chains?: Chain[]
   defaultChain?: Chain
   chainImages?: Record<number, string>
   connectorImages?: Record<string, string>
@@ -95,7 +95,7 @@ export class Web3Modal extends Web3ModalScaffold {
 
   private projectId: string
 
-  private chains?: Chain[]
+  private chains: Chain[]
 
   private metadata?: Metadata
 
@@ -423,7 +423,7 @@ export class Web3Modal extends Web3ModalScaffold {
             return map
           }, {})
         : ({} as Record<number, string>),
-      optionalChains: this.chains ? [0, ...this.chains.map(chain => chain.chainId)] : [0],
+      optionalChains: [...this.chains.map(chain => chain.chainId)] as [number],
       metadata: {
         name: this.metadata ? this.metadata.name : '',
         description: this.metadata ? this.metadata.description : '',

diff --git a/packages/ethers5/src/client.ts b/packages/ethers5/src/client.ts
@@ -34,7 +34,7 @@ import type { EthereumProviderOptions } from '@walletconnect/ethereum-provider'
 export interface Web3ModalClientOptions extends Omit<LibraryOptions, 'defaultChain' | 'tokens'> {
   ethersConfig: ProviderType
   siweConfig?: Web3ModalSIWEClient
-  chains?: Chain[]
+  chains: Chain[]
   defaultChain?: Chain
   chainImages?: Record<number, string>
   connectorImages?: Record<string, string>
@@ -87,7 +87,7 @@ export class Web3Modal extends Web3ModalScaffold {
 
   private projectId: string
 
-  private chains?: Chain[]
+  private chains: Chain[]
 
   private metadata?: Metadata
 
@@ -393,7 +393,7 @@ export class Web3Modal extends Web3ModalScaffold {
             return map
           }, {})
         : ({} as Record<number, string>),
-      optionalChains: this.chains ? [0, ...this.chains.map(chain => chain.chainId)] : [0],
+      optionalChains: [...this.chains.map(chain => chain.chainId)] as [number],
       metadata: {
         name: this.metadata ? this.metadata.name : '',
         description: this.metadata ? this.metadata.description : '',