refactor: SafeLocalStorage

reown-com · Sep 23, 2024 · 671f2d1 · 671f2d1
1 parent 2a75488
commit 671f2d1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 7 deletions.
diff --git a/packages/common/src/utils/SafeLocalStorage.ts b/packages/common/src/utils/SafeLocalStorage.ts
@@ -30,7 +30,10 @@ export const SafeLocalStorage = {
     value: SafeLocalStorageItems[Key]
   ): void {
     if (isSafe()) {
-      localStorage.setItem(key, JSON.stringify(value))
+      localStorage.setItem(
+        key,
+        key === SafeLocalStorageKeys.DEEPLINK_CHOICE ? JSON.stringify(value) : (value as string)
+      )
     }
   },
   getItem<Key extends keyof SafeLocalStorageItems>(
@@ -40,11 +43,15 @@ export const SafeLocalStorage = {
       const value = localStorage.getItem(key)
 
       if (value) {
-        try {
-          return JSON.parse(value)
-        } catch {
-          return undefined
+        if (key === SafeLocalStorageKeys.DEEPLINK_CHOICE) {
+          try {
+            return JSON.parse(value)
+          } catch {
+            return undefined
+          }
         }
+
+        return value as SafeLocalStorageItems[Key]
       }
     }
 

diff --git a/packages/common/tests/SafeLocalStorage.test.ts b/packages/common/tests/SafeLocalStorage.test.ts
@@ -26,7 +26,7 @@ describe('SafeLocalStorage unsafe', () => {
 describe('SafeLocalStorage safe', () => {
   let getItem = vi.fn(value => {
     if (value === '@appkit/wallet_id') {
-      return JSON.stringify('test')
+      return 'test'
     }
 
     return undefined
@@ -46,7 +46,7 @@ describe('SafeLocalStorage safe', () => {
 
   it('should setItem', () => {
     expect(SafeLocalStorage.setItem('@appkit/wallet_id', 'test')).toBe(undefined)
-    expect(setItem).toHaveBeenCalledWith('@appkit/wallet_id', JSON.stringify('test'))
+    expect(setItem).toHaveBeenCalledWith('@appkit/wallet_id', 'test')
   })
 
   it('should getItem ', () => {