feat: add name to connect event. Remove external type and replace wit…

…h browser
reown-com · Feb 15, 2024 · d414a31 · d414a31
1 parent 937edb0
commit d414a31
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 7 deletions.
diff --git a/packages/core/src/utils/TypeUtil.ts b/packages/core/src/utils/TypeUtil.ts
@@ -216,7 +216,8 @@ export type Event =
       type: 'track'
       event: 'CONNECT_SUCCESS'
       properties: {
-        method: 'qrcode' | 'mobile' | 'external' | 'browser' | 'email'
+        method: 'qrcode' | 'mobile' | 'browser' | 'email'
+        name: string
       }
     }
   | {

diff --git a/packages/core/tests/controllers/AssetController.test.ts b/packages/core/tests/controllers/AssetController.test.ts
@@ -8,7 +8,8 @@ describe('AssetController', () => {
       walletImages: {},
       networkImages: {},
       connectorImages: {},
-      tokenImages: {}
+      tokenImages: {},
+      currencyImages: {}
     })
   })
 })
diff --git a/packages/core/tests/controllers/TransactionsController.test.ts b/packages/core/tests/controllers/TransactionsController.test.ts
@@ -9,7 +9,8 @@ describe('TransactionsController', () => {
       transactionsByYear: {},
       loading: false,
       empty: false,
-      next: undefined
+      next: undefined,
+      coinbaseTransactions: []
     })
   })
 })
diff --git a/packages/scaffold/src/partials/w3m-connecting-wc-browser/index.ts b/packages/scaffold/src/partials/w3m-connecting-wc-browser/index.ts
@@ -43,7 +43,7 @@ export class W3mConnectingWcBrowser extends W3mConnectingWidget {
       EventsController.sendEvent({
         type: 'track',
         event: 'CONNECT_SUCCESS',
-        properties: { method: 'browser' }
+        properties: { method: 'browser', name: this.wallet?.name || 'Unknown' }
       })
     } catch (error) {
       EventsController.sendEvent({

diff --git a/packages/scaffold/src/views/w3m-connecting-external-view/index.ts b/packages/scaffold/src/views/w3m-connecting-external-view/index.ts
@@ -54,7 +54,7 @@ export class W3mConnectingExternalView extends W3mConnectingWidget {
         EventsController.sendEvent({
           type: 'track',
           event: 'CONNECT_SUCCESS',
-          properties: { method: 'external' }
+          properties: { method: 'browser', name: this.connector.name || 'Unknown' }
         })
       }
     } catch (error) {

diff --git a/packages/scaffold/src/views/w3m-connecting-wc-view/index.ts b/packages/scaffold/src/views/w3m-connecting-wc-view/index.ts
@@ -111,7 +111,8 @@ export class W3mConnectingWcView extends LitElement {
       type: 'track',
       event: 'CONNECT_SUCCESS',
       properties: {
-        method: wcLinking ? 'mobile' : 'qrcode'
+        method: wcLinking ? 'mobile' : 'qrcode',
+        name: this.wallet?.name || 'Unknown'
       }
     })
   }

diff --git a/packages/scaffold/src/views/w3m-email-verify-otp-view/index.ts b/packages/scaffold/src/views/w3m-email-verify-otp-view/index.ts
@@ -20,7 +20,7 @@ export class W3mEmailVerifyOtpView extends W3mEmailOtpWidget {
         EventsController.sendEvent({
           type: 'track',
           event: 'CONNECT_SUCCESS',
-          properties: { method: 'email' }
+          properties: { method: 'email', name: this.emailConnector.name || 'Unknown' }
         })
       }
     } catch (error) {