Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Platform switching refactor #1235

Merged
merged 14 commits into from
Jul 31, 2023
Merged

[v3] Platform switching refactor #1235

merged 14 commits into from
Jul 31, 2023

Conversation

xzilja
Copy link
Contributor

@xzilja xzilja commented Jul 28, 2023

Changes

  • Update deps
  • Add new ui components
  • Update existing ui components
  • Refactor platform switching to use tabs

@xzilja xzilja requested a review from svenvoskamp July 28, 2023 13:04
@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 1:07pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 1:07pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 28, 2023

Fails
🚫 packages/ui/src/composites/wui-tabs/index.ts is using @State decorator, which is not allowd in ui package

Generated by 🚫 dangerJS against f9a5e13

@xzilja
Copy link
Contributor Author

xzilja commented Jul 28, 2023

Ignoring dangerjs here for internal tabs state (tracks active tab)

@xzilja xzilja merged commit f1513d5 into V3 Jul 31, 2023
7 checks passed
@xzilja xzilja deleted the v-3/mobile-deeplinking branch July 31, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants