Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V 3/tabs #1311

Merged
merged 21 commits into from
Sep 6, 2023
Merged

V 3/tabs #1311

merged 21 commits into from
Sep 6, 2023

Conversation

svenvoskamp
Copy link
Contributor

Changes

  • feat: Implemented collapsed tab solution when tabs length > 3

@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
c9db2a3
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
797a677
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
5bb31c4
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
9d7d7fb
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
e4751ef
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
c283ab2
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
035cfef
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
44b0366
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
f00815b
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
482e54e
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
bf7059a
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
362f940
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
9b91647
@svenvoskamp
wip
dfee7f2
@svenvoskamp
tab refactor if length > 3
6dc5f3c
@vercel
Copy link

vercel bot commented Sep 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 6, 2023 1:49pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Sep 6, 2023 1:49pm
web3modal-react-wagmi-ex ❌ Failed (Inspect) Sep 6, 2023 1:49pm
web3modal-vue-wagmi-ex ❌ Failed (Inspect) Sep 6, 2023 1:49pm

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023 •
edited
Loading

Warnings
⚠️ No version updates in packages/wagmi/src/utils/constants.ts file

Generated by 🚫 dangerJS against 36c75a7

@svenvoskamp svenvoskamp marked this pull request as ready for review September 6, 2023 07:44
xzilja
xzilja suggested changes Sep 6, 2023
View reviewed changes
packages/ui/src/composites/wui-tabs/index.ts Show resolved Hide resolved
packages/ui/src/composites/wui-tabs/index.ts Outdated Show resolved Hide resolved
packages/ui/src/composites/wui-tabs/index.ts Outdated Show resolved Hide resolved
packages/ui/src/composites/wui-tabs/index.ts Outdated Show resolved Hide resolved
packages/ui/src/composites/wui-tabs/index.ts Show resolved Hide resolved
xzilja
xzilja suggested changes Sep 6, 2023
View reviewed changes
packages/ui/src/composites/wui-tabs/index.ts Outdated Show resolved Hide resolved
packages/ui/package.json Show resolved Hide resolved
@svenvoskamp svenvoskamp merged commit 339793f into V3 Sep 6, 2023
6 checks passed
@svenvoskamp svenvoskamp deleted the v-3/tabs branch September 6, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzilja xzilja xzilja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenvoskamp @xzilja