Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V 3 / beta polish #1320

Merged
merged 23 commits into from
Sep 8, 2023
Merged

V 3 / beta polish #1320

merged 23 commits into from
Sep 8, 2023

Conversation

svenvoskamp
Copy link
Contributor

Changes

  • disabled ui states when mobile is in connecting view
  • correct amount of loaders
  • correct truncation in account for ENS

@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
c9db2a3
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
797a677
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
5bb31c4
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
9d7d7fb
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
e4751ef
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
c283ab2
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
035cfef
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
44b0366
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
f00815b
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
482e54e
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
bf7059a
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
362f940
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
9b91647
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
83fa048
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
b35eb4b
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
343d084
@svenvoskamp
various issues resolved
bdb6ce9
@vercel
Copy link

vercel bot commented Sep 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 8, 2023 1:45pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Sep 8, 2023 1:45pm
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Sep 8, 2023 1:45pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Sep 8, 2023 1:45pm

@svenvoskamp svenvoskamp marked this pull request as ready for review September 8, 2023 10:28
xzilja
xzilja suggested changes Sep 8, 2023
View reviewed changes
packages/scaffold/src/partials/w3m-connecting-header/index.ts Outdated Show resolved Hide resolved
packages/scaffold/src/partials/w3m-connecting-header/index.ts Outdated Show resolved Hide resolved
packages/scaffold/src/partials/w3m-connecting-wc-mobile/index.ts Outdated Show resolved Hide resolved
packages/scaffold/src/partials/w3m-header/index.ts Outdated Show resolved Hide resolved
packages/scaffold/src/partials/w3m-header/index.ts Outdated Show resolved Hide resolved
packages/ui/src/composites/wui-account-button/index.ts Outdated Show resolved Hide resolved
packages/ui/src/composites/wui-account-button/index.ts Outdated Show resolved Hide resolved
packages/ui/src/utils/UiHelperUtils.ts Outdated Show resolved Hide resolved
xzilja
xzilja reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@xzilja xzilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need / substantial higher character limit should be used for ens and normal address truncation in account view.

  1. Address should be [4]...[4] as before
  2. Profile name should be as long as possible before it breaks things

Uploading Screenshot 2023-09-08 at 15.59.15.png…

packages/ui/src/utils/UiHelperUtils.ts Outdated Show resolved Hide resolved
xzilja
xzilja approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@xzilja xzilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for addressing all comments 🙏

@svenvoskamp svenvoskamp merged commit a1779ac into V3 Sep 8, 2023
6 checks passed
@svenvoskamp svenvoskamp deleted the v-3/beta-polish branch September 8, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzilja xzilja xzilja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenvoskamp @xzilja