Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect network order when connected with wc #1576

Merged
merged 10 commits into from
Dec 19, 2023
Merged

Conversation

svenvoskamp
Copy link
Contributor

@svenvoskamp svenvoskamp commented Dec 15, 2023

Changes

  • fix: Fix incorrect network order when connected with wc

Associated Issues

closes #1388

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Dec 18, 2023 1:42pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Dec 18, 2023 1:42pm
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Dec 18, 2023 1:42pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Dec 18, 2023 1:42pm

enesozturk
enesozturk previously approved these changes Dec 15, 2023
Copy link
Contributor

@enesozturk enesozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to have a unit/functional test?

@svenvoskamp
Copy link
Contributor Author

Does this need to have a unit/functional test?

It makes sense to do some functional testing here as the order depends on the specific wallet you're connected with.

@svenvoskamp svenvoskamp merged commit 9cea47e into V3 Dec 19, 2023
12 checks passed
@svenvoskamp svenvoskamp deleted the fix/wc-chain-order branch December 19, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Chains not displayed not in order of chains config when using WalletConnect
3 participants