Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-test): cover siwe #1679

Merged
merged 3 commits into from
Dec 29, 2023
Merged

feat(ui-test): cover siwe #1679

merged 3 commits into from
Dec 29, 2023

Conversation

arein
Copy link
Contributor

@arein arein commented Dec 29, 2023 •
edited
Loading

Changes

  • feat(ui-test): cover siwe

Associated Issues

closes #...

@vercel Vercel
Copy link

vercel bot commented Dec 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Dec 29, 2023 2:14am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Dec 29, 2023 2:14am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Dec 29, 2023 2:14am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Dec 29, 2023 2:14am

chris13524
chris13524 requested changes Dec 29, 2023
View reviewed changes
Copy link
Member

@chris13524 chris13524 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 blocker, rest are non-blocking

.github/workflows/ui_tests.yml Show resolved Hide resolved
apps/laboratory/tests/shared/pages/ModalPage.ts Outdated Show resolved Hide resolved
apps/laboratory/tests/shared/validators/ModalValidator.ts Outdated Show resolved Hide resolved
apps/laboratory/tests/shared/fixtures/w3m-wallet-fixture.ts Show resolved Hide resolved
Cali93
Cali93 approved these changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@Cali93 Cali93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waw, ty so much for this 🙏

@arein arein mentioned this pull request Dec 29, 2023
Closed
13 tasks
@arein arein merged commit 2ec21ef into V3 Dec 29, 2023
12 checks passed
@arein arein deleted the feat/siwe-test branch December 29, 2023 12:33
@tomiir tomiir mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali93 Cali93 Cali93 approved these changes

@chris13524 chris13524 chris13524 approved these changes

@tomiir tomiir Awaiting requested review from tomiir

@svenvoskamp svenvoskamp Awaiting requested review from svenvoskamp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arein @chris13524 @Cali93