Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: capped networks view grid height to 70vh #1701

Merged
merged 3 commits into from
Jan 4, 2024
Merged

fix: capped networks view grid height to 70vh #1701

merged 3 commits into from
Jan 4, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Jan 3, 2024 •
edited
Loading

Breaking Changes

N/A

Changes

  • feat:
  • fix: networks view max-height
  • chore:

Related issues

Closes Peanut : Network Switching interface issue#1703

@vercel Vercel
Copy link

vercel bot commented Jan 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jan 4, 2024 3:01pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jan 4, 2024 3:01pm
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Jan 4, 2024 3:01pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Jan 4, 2024 3:01pm

@svenvoskamp
Copy link
Contributor

svenvoskamp commented Jan 4, 2024 •
edited
Loading

For the all-wallets-view we use 360px as fixed height. Can we stick to this?

Also please add the following code in the css, so scrollbar is hidden

wui-grid::-webkit-scrollbar {
    display: none;
}

@tomiir tomiir mentioned this pull request Jan 4, 2024
Closed
@tomiir tomiir merged commit 080d222 into V3 Jan 4, 2024
12 checks passed
@tomiir tomiir deleted the fix/networks-max-height branch January 4, 2024 15:17
@tomiir tomiir mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenvoskamp svenvoskamp svenvoskamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Peanut : Network Switching interface issue
2 participants
@tomiir @svenvoskamp