Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix balance #1838

Merged
merged 4 commits into from
Jan 29, 2024
Merged

fix balance #1838

merged 4 commits into from
Jan 29, 2024

Conversation

glitch-txs
Copy link
Contributor

Breaking Changes

N/A

Changes

  • fix: If the chain wasn't in config we were fetching the balance of the defaultChain or the first configured chain which is inacurated data from the current connected chain, this PR will skip the fetch of the balance and set it directly to 0.000 if the chain is not registered.

Notice:

  • We cannot fetch the balance of an unregistered chain because Wagmi function will throw an error + we don't have the symbol info to display in the UI
  • We should have a UI view to show the user is on an incorrected chain

Associated Issues

closes #1836

Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jan 29, 2024 9:24pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jan 29, 2024 9:24pm
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Jan 29, 2024 9:24pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Jan 29, 2024 9:24pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants