feat(canary): export web3modal Canary image #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
arein
changed the title
tomiir
reviewed
Feb 8, 2024
tomiir
reviewed
Feb 8, 2024
Comment on lines
+20
to
+22
| if (browserName !== 'chromium' || modalPage.library !== 'ethers') { | ||
| return | ||
| } |
There was a problem hiding this comment.
could be abstracted under your 3 time no-repeat rule but not a big deal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple Playwright test to get full end-2-end confidence/latency metrics including:
Testing
Built successfully into ECR and tested locally
https://github.com/WalletConnect/web3modal/actions/runs/7835190121/job/21380181938
Changes
Associated Issues
closes #...