Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify connection events #1929

Merged
merged 7 commits into from
Feb 29, 2024
Merged

feat: unify connection events #1929

merged 7 commits into from
Feb 29, 2024

Conversation

tomiir
Copy link
Collaborator

@tomiir tomiir commented Feb 15, 2024

Breaking Changes

N/A

Changes

  • feat:
  • fix: add name to connect event. Remove external type and replace with browser type
  • chore:

Associated Issues

closes
#1928

@tomiir tomiir marked this pull request as ready for review February 15, 2024 14:14
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Feb 29, 2024 2:25am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Feb 29, 2024 2:25am
web3modal-react-wagmi-ex 🛑 Canceled (Inspect) Feb 29, 2024 2:25am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Feb 29, 2024 2:25am

dnul
dnul previously approved these changes Feb 15, 2024
Copy link

@dnul dnul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, see comments

svenvoskamp
svenvoskamp previously approved these changes Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants