Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve UI tests #1932

Merged
merged 6 commits into from
Feb 16, 2024
Merged

fix: improve UI tests #1932

merged 6 commits into from
Feb 16, 2024

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Feb 15, 2024 •
edited
Loading

Various fixes/improvements to the UI tests:

  • Fix that wrong environment variable was used. ENV -> ENVIRONMENT
  • Fix that getByTestId() does not appear to work for me, resulting in test failures
  • Filter canary execution by project, rather than special logic in the test
  • Run the canary test as part of regular CI here, so we know it's always correct
  • Standardize on .env.local & update some readmes
  • Rename Dockerfile to Dockerfile.canary so it's more clear what it's for

Slack conversation

@chris13524 chris13524 self-assigned this Feb 15, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Feb 16, 2024 2:36pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Feb 16, 2024 2:36pm
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Feb 16, 2024 2:36pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Feb 16, 2024 2:36pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited
Loading

Warnings
⚠️ Changes were made to one or more package.json(s), but not to package-lock.json

Generated by 🚫 dangerJS against 29531c7

lukaisailovic
lukaisailovic previously approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@lukaisailovic lukaisailovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!

arein
arein previously approved these changes Feb 16, 2024
View reviewed changes
apps/laboratory/package.json Show resolved Hide resolved
@chris13524 chris13524 merged commit f2cb5c6 into V4 Feb 16, 2024
13 checks passed
@chris13524 chris13524 deleted the fix/improve-ui-tests branch February 16, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaisailovic lukaisailovic lukaisailovic approved these changes

@arein arein Awaiting requested review from arein

Assignees

@chris13524 chris13524

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris13524 @arein @lukaisailovic