Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent users from seeing email icon while logged in through walletconnect #1965

Merged
merged 11 commits into from
Feb 22, 2024

Conversation

svenvoskamp
Copy link
Contributor

Changes

  • fix: We didn't set connectedConnector when connected with WC. This resulted in showing the email icon when you were connected with email and then connected with WC.

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Feb 22, 2024 1:22pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Feb 22, 2024 1:22pm
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Feb 22, 2024 1:22pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Feb 22, 2024 1:22pm

@svenvoskamp svenvoskamp merged commit 429d65c into V4 Feb 22, 2024
13 checks passed
@svenvoskamp svenvoskamp deleted the fix/email-icon-issue branch February 22, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants