Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:feat add send wallet feature #2038

Merged
merged 30 commits into from
Mar 14, 2024
Merged

:feat add send wallet feature #2038

merged 30 commits into from
Mar 14, 2024

Conversation

svenvoskamp
Copy link
Contributor

@svenvoskamp svenvoskamp commented Mar 11, 2024 •
edited
Loading

  • Add wui-input-amount component
  • Add wui-preview-item component
  • Add wui-token-button component
  • Add w3m-input-token partial
  • Add w3m-input-address partial
  • Add w3m-wallet-send-details partial
  • Add w3m-wallet-send-view view
  • Add w3m-wallet-send-select-token view
  • Add w3m-wallet-send-preview view
  • Add SendController

@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
8b4902d
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
63cfbe3
@svenvoskamp
merge
2b52d4b
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
2e83f78
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
001253d
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
6bc579d
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
d591a36
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
0bbd3ce
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
dbec76d
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
c6cc0da
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
abea3f9
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
9de5915
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
450ff30
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
a194234
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
8e2b240
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
ecdfd22
@svenvoskamp
Merge branch 'V4' of github.com:WalletConnect/web3modal into V4
e9d2565
@svenvoskamp
add send flow
9ed4807
@vercel Vercel
Copy link

vercel bot commented Mar 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Mar 14, 2024 1:49pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Mar 14, 2024 1:49pm
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Mar 14, 2024 1:49pm
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Mar 14, 2024 1:49pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 11, 2024 •
edited
Loading

Fails
🚫 New composites were added, but not exported in ui/utils/JSXTypeUtil.ts

Generated by 🚫 dangerJS against e8a6650

@svenvoskamp svenvoskamp marked this pull request as ready for review March 11, 2024 15:02
tomiir
tomiir reviewed Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but looks good overall!

packages/scaffold/src/partials/w3m-input-address/index.ts Outdated Show resolved Hide resolved
packages/scaffold/src/partials/w3m-input-token/index.ts Show resolved Hide resolved
packages/scaffold/src/views/w3m-wallet-send-view/index.ts Outdated Show resolved Hide resolved
packages/ui/src/composites/wui-input-amount/index.ts Outdated Show resolved Hide resolved
packages/ui/src/composites/wui-tag/styles.ts Show resolved Hide resolved
@svenvoskamp svenvoskamp requested a review from tomiir March 14, 2024 10:34
tomiir
tomiir approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@tomiir tomiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@svenvoskamp svenvoskamp merged commit 5f44461 into V4 Mar 14, 2024
12 of 13 checks passed
@svenvoskamp svenvoskamp deleted the feat/send-wallet-feature branch March 14, 2024 13:50
@tomiir tomiir mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomiir tomiir tomiir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenvoskamp @tomiir